Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc as second params to validation message function #12651

Merged
merged 3 commits into from Nov 27, 2022

Conversation

IslandRhythms
Copy link
Collaborator

No description provided.

@IslandRhythms IslandRhythms linked an issue Nov 2, 2022 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it looks like your test asserts that your fix doesn't work :( let's take a look at this and see what's wrong.

lib/error/validator.js Outdated Show resolved Hide resolved
test/schema.validation.test.js Outdated Show resolved Hide resolved
test/schema.validation.test.js Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 merged commit 035218b into 6.8 Nov 27, 2022
@vkarpov15 vkarpov15 deleted the IslandRhythms/validation-function-doc-param branch November 27, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doc as 2nd parameter to validation message function
2 participants