Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add UUID to types #12650

Merged
merged 3 commits into from Nov 4, 2022
Merged

fix(types): add UUID to types #12650

merged 3 commits into from Nov 4, 2022

Conversation

vkarpov15
Copy link
Collaborator

Fix #12593
Re: #12268
Re: #3208

Summary

Missed adding TS definitions for #12268. This makes it possible to use UUIDs in TS schemas, including with InferSchemaType.

Examples

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Nov 2, 2022
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though have not tested yet

should maybe be types-tests be added for confirming that the UUID actually works when returned from finds, works in create / new (document) and also with lean?

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 merged commit cdfc84f into master Nov 4, 2022
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12593 branch November 4, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UUID is missing from Types in 6.7.0 release
2 participants