Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Links to not link to api.html anymore #12644

Merged
merged 9 commits into from Dec 1, 2022

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Nov 2, 2022

Summary

This PR changes links that pointed to api.html to a more proper place.
Most commits are cherry-picked from #12223, though some changes have been made.

All Changes:

  • Change links (both in docs and code) to not link to api.html anymore but to more proper places
  • fix some EOF lines in files (remove duplicate EOF lines and add missing ones)
  • remove links from collection.d.ts because there were invalid (even before the change of this PR)

Changes from the commits in #12223:

  • verified that the links updated are actually mongoose links (fixes some express links that have been accidentally changed)

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Nov 2, 2022
@hasezoey
Copy link
Collaborator Author

Updated to resolve conflicts from #12623

@hasezoey hasezoey added this to the 6.7.3 milestone Nov 14, 2022
@vkarpov15 vkarpov15 modified the milestones: 6.7.3, 6.7.4, 6.7.5 Nov 22, 2022
@vkarpov15 vkarpov15 modified the milestones: 6.7.5, 6.8 Nov 30, 2022
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus one minor comment

docs/guide.md Outdated
For example, we've defined a property `title` which will be cast to the
[String](./api.html#schema-string-js) SchemaType and property `date`
[String](./api/schema-string-js.html#schema-string-js) SchemaType and property `date`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is broken. It was also broken before. Should just link here: https://mongoosejs.com/docs/schematypes.html#strings

@vkarpov15 vkarpov15 changed the base branch from master to 6.8 December 1, 2022 22:42
@vkarpov15 vkarpov15 merged commit bc750fd into Automattic:6.8 Dec 1, 2022
@hasezoey hasezoey deleted the changeLinksFromAPI branch December 2, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants