Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): allow overwriting discriminator key with overwriteDiscriminatorKey if strict: 'throw' #12578

Merged
merged 2 commits into from Oct 21, 2022
Merged

fix(query): allow overwriting discriminator key with overwriteDiscriminatorKey if strict: 'throw' #12578

merged 2 commits into from Oct 21, 2022

Conversation

vkarpov15
Copy link
Collaborator

Fix #12513

Summary

A couple of quick fixes for how we handle overwriteDiscriminatorKey. overwriteDiscriminatorKey should overwrite strict: 'throw'.

Examples

IslandRhythms
IslandRhythms approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 merged commit 7cd8ea3 into master Oct 21, 2022
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12513 branch October 21, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IslandRhythms IslandRhythms IslandRhythms approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@hasezoey hasezoey Awaiting requested review from hasezoey

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StrictModeError: Throw when setting discriminator field
2 participants
@vkarpov15 @IslandRhythms