fix: correct browser build and improve isAsyncFunction check for browser

[vkarpov15]

Re: #12576

Summary

A couple of related fixes:

1. Fix the issue that was causing browser build to fail
2. Remove dist to prevent accidentally publishing out-of-date browser build if build-browser fails
3. Use a different approach for isAsyncFunction() based on this SO thread, because our current approach doesn't seem to work very well when compiled through Babel. I suspect the issue is that Babel converts Object.getPrototypeOf(async function() {}); to Object.getPrototypeOf(function() {}); under the hood.

Examples

[AbdelrahmanHafez]

LGTM, thanks 👍

[clathey123]

I am using Node and Mongoose in a reactjs project. Yesterday I installed the validation module in NPM and did an audit fix. One of these actions triggered the issue with the browser.umd file that is described above. Today I went to verify the version of mongoose that I am using and I get an error "Invalid version mongoose". I went to the log file noted in this invalid version error and I found the attached text.

I am relatively new to this "world" and have no idea what I should do to resolve the initial 'split' issue or the invalid version. Can you help?

Thank you! Cheryl
2022-10-30T14_30_47_341Z-debug-0.log

[hasezoey]

@clathey123 next time please open a new issue

from the error verbose stack Error: Invalid version: mongoose and some doing searching, it seems you have set some package to version mongoose (ie set something like "some-package": "mongoose", which is a invalid version

[clathey123]

Thanks for the reply... next time I will open a new issue. Sorry, I don't know how I would have set a package to "mongoose" or how to find or fix. I did a search for ": "mongoose" and did not find anything. Any ideas on how I would find and fix this?

[hasezoey]

Sorry, I don't know how I would have set a package to "mongoose" or how to find or fix. I did a search for ": "mongoose" and did not find anything. Any ideas on how I would find and fix this?

the only guess i would have is in the package.json, just search for mongoose, otherwise also maybe look into the lockfile if used (or try to delete the lockfile), aside from that, try to check that the syntax of the json is actually correct and not missing any characters
what could also be the problem is something in node_modules, try to remove and reinstall it

[clathey123]

Hello again! I wanted to let you know that I figured out the mongoose version issue. It seems to be the syntax of the command that I used. When I used "npm v mongoose" (instead of spelling out the word version), it worked as expected. YAY! I have another question for you that I'm hoping you can help with.... I took your advice and posted a new issue regarding the "browser.umd" issue that I am having.... I posted the issue on Sunday and have not heard anything. This is frustrating as I am unable to do any development until this issue is resolved. Here is a link to the post that I made.... valerie-thomas/nestegg#1 (comment).... Did I post this correctly??? If so, any idea when someone might reply? Thanks for the assist!!! Cheryl

…

On Sun, Oct 30, 2022 at 10:09 AM hasezoey ***@***.***> wrote: Sorry, I don't know how I would have set a package to "mongoose" or how to find or fix. I did a search for ": "mongoose" and did not find anything. Any ideas on how I would find and fix this? the only guess i would have is in the package.json, just search for mongoose, otherwise also maybe look into the lockfile if used (or try to delete the lockfile), aside from that, try to check that the syntax of the json is actually correct and not missing any characters what could also be the problem is something in node_modules, try to remove and reinstall it — Reply to this email directly, view it on GitHub <#12577 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUURXQRHJK3GFRYUU5M74WDWF2FSJANCNFSM6AAAAAARLKVOP4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[clathey123]

Please ignore this email... I think I figured out how to post the issue correctly. The new issue has been given #12639. Sorry for the extra emails! Thank you! Cheryl

…

On Tue, Nov 1, 2022 at 4:42 PM Cheryl Athey ***@***.***> wrote: Hello again! I wanted to let you know that I figured out the mongoose version issue. It seems to be the syntax of the command that I used. When I used "npm v mongoose" (instead of spelling out the word version), it worked as expected. YAY! I have another question for you that I'm hoping you can help with.... I took your advice and posted a new issue regarding the "browser.umd" issue that I am having.... I posted the issue on Sunday and have not heard anything. This is frustrating as I am unable to do any development until this issue is resolved. Here is a link to the post that I made.... valerie-thomas/nestegg#1 (comment).... Did I post this correctly??? If so, any idea when someone might reply? Thanks for the assist!!! Cheryl On Sun, Oct 30, 2022 at 10:09 AM hasezoey ***@***.***> wrote: > Sorry, I don't know how I would have set a package to "mongoose" or how > to find or fix. I did a search for ": "mongoose" and did not find anything. > Any ideas on how I would find and fix this? > > the only guess i would have is in the package.json, just search for > mongoose, otherwise also maybe look into the lockfile if used (or try to > delete the lockfile), aside from that, try to check that the syntax of the > json is actually correct and not missing any characters > what could also be the problem is something in node_modules, try to > remove and reinstall it > > — > Reply to this email directly, view it on GitHub > <#12577 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AUURXQRHJK3GFRYUU5M74WDWF2FSJANCNFSM6AAAAAARLKVOP4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >