Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cast): make schema-level strictQuery override schema-level strict for query filters #12570

Merged
merged 3 commits into from Oct 20, 2022
Merged

fix(cast): make schema-level strictQuery override schema-level strict for query filters #12570

merged 3 commits into from Oct 20, 2022

Conversation

vkarpov15
Copy link
Collaborator

Fix #12508

Summary

Looks like schema-level strict overrides schema-level strictQuery, which is definitely not something we want given that we want to switch strictQuery back to false by default.

Examples

AbdelrahmanHafez
AbdelrahmanHafez reviewed Oct 19, 2022
View reviewed changes
lib/cast.js Outdated Show resolved Hide resolved
AbdelrahmanHafez
AbdelrahmanHafez requested changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One refactor suggestion, but otherwise LGTM. Thanks 👍

IslandRhythms
IslandRhythms approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 merged commit dcbff09 into master Oct 20, 2022
@AbdelrahmanHafez AbdelrahmanHafez deleted the vkarpov15/gh-12508 branch October 20, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez requested changes

@IslandRhythms IslandRhythms IslandRhythms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option strict is used before Schema and global level strictQuery
3 participants
@vkarpov15 @AbdelrahmanHafez @IslandRhythms