fix(document): allow creating document with document array and top-level key named `schema` #12569

vkarpov15 · 2022-10-19T20:30:45Z

Summary

Looks like we missed a spot when we allowed using schema as a top-level key: DocumentArray/index.js still uses doc.schema rather than doc.$__schema

Examples

…vel key named `schema` Fix #12480

AbdelrahmanHafez

LGTM, thanks! 👍

fix(document): allow creating document with document array and top-le…

3141cb6

…vel key named `schema` Fix #12480

vkarpov15 requested review from AbdelrahmanHafez and IslandRhythms October 19, 2022 20:30

AbdelrahmanHafez approved these changes Oct 19, 2022

View reviewed changes

vkarpov15 merged commit 9133393 into master Oct 20, 2022

vkarpov15 deleted the vkarpov15/gh-12480 branch October 20, 2022 17:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(document): allow creating document with document array and top-level key named `schema` #12569

fix(document): allow creating document with document array and top-level key named `schema` #12569

vkarpov15 commented Oct 19, 2022

AbdelrahmanHafez left a comment

fix(document): allow creating document with document array and top-level key named schema #12569

fix(document): allow creating document with document array and top-level key named schema #12569

Conversation

vkarpov15 commented Oct 19, 2022

AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

fix(document): allow creating document with document array and top-level key named `schema` #12569

fix(document): allow creating document with document array and top-level key named `schema` #12569