feat(document): add $clone method #12549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well I dont know if we want this feature. So we need feedback from @vkarpov15 But I know for sure, that we have to keep in mind that Object.assign does only a shallow Copy. So what happens with deep nested objects? We need tests for that case. |
vkarpov15
requested changes
Oct 17, 2022
test/document.test.js
Outdated
|
|
||
| assert.deepEqual(doc, clonedDoc); | ||
| assert.deepEqual(doc._doc, clonedDoc._doc); | ||
| assert.deepEqual(doc.$__, clonedDoc.$__); |
There was a problem hiding this comment.
I'd like to add some extra test cases to make sure this $clone() method works. For example:
- Modify a field in
clonedDoc. Make sure that the field is modified inclonedDoc, but not indoc. - Save
clonedDoc. Make sure that doesn't affect modified paths ondoc. - Add a value that fails validation to
doc. Runawait doc.validate(). Then create a new cloned docclonedDoc = doc.$clone(), fix the invalid value, runawait clonedDoc.validate(). Make sure the path is still invalid inclonedDoc. - Set a session on
clonedDoc, make sure that doesn't affect the original doc.
lib/document.js
Outdated
| clonedDoc._doc = clone(this._doc); | ||
| } | ||
| if (this.$__) { | ||
| clonedDoc.$__ = Object.assign(Object.create(Object.getPrototypeOf(this.$__)), this.$__); |
There was a problem hiding this comment.
We would need to do a deep clone on $__, that may contain deeply nested properties.
lib/document.js
Outdated
| */ | ||
|
|
||
| Document.prototype.$clone = function() { | ||
| const clonedDoc = Object.assign(Object.create(Object.getPrototypeOf(this)), this); |
There was a problem hiding this comment.
I really don't like using Object.create() like this, because Object.create() skips running the Document constructor. I'd try just using const Model = this.constructor; const clonedDoc = new Model();
lpizzinidev
force-pushed
the
feat-doc-clone
branch
from
9de86f0
to
c7f051e
Compare
2 tasks
vkarpov15
approved these changes
Oct 24, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11849
Not sure if this is the best approach.
Anyway, open to feedback.