Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aggregation): add $fill pipeline stage #12545

Merged
merged 15 commits into from Oct 17, 2022

Conversation

raphael-papazikas
Copy link
Contributor

hasezoey and others added 15 commits October 6, 2022 09:41
densify pipeline stage was not in the union type
for PipelineStage, this was causing ts error when
users where trying to call aggregate method with
densify stage
…ing-densify-stage-on-pipeline-stages-type

Add missing densify type pipeline type
replaceWith pipeline stage was not accepting a field
as a parameter. This was causing ts error when
users where trying to call aggregate method with
replaceWith stage in unusual ways
docs(guide): update broken read-preference links
docs(connection): improved useDb() documentation
…eplace-with-stage-on-pipeline-stages-type

Adjust replaceWith type pipeline stage
…late

chore(template::bug): add field for typescript version
Automatticgh-12536: add tests


revert some


remove operators


enhance type


fix example
@hasezoey hasezoey added the enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature label Oct 14, 2022
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@@ -111,11 +111,11 @@ Aggregate.prototype.model = function(model) {
this._model = model;
if (model.schema != null) {
if (this.options.readPreference == null &&
model.schema.options.read != null) {
model.schema.options.read != null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, please avoid making these sort of minor style changes. They make it harder to review your code.

@vkarpov15 vkarpov15 added this to the 6.7 milestone Oct 17, 2022
@vkarpov15 vkarpov15 changed the base branch from master to 6.7 October 17, 2022 18:22
@vkarpov15 vkarpov15 merged commit bed6d81 into Automattic:6.7 Oct 17, 2022
@raphael-papazikas raphael-papazikas deleted the feature/12536-fill-stage branch November 23, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for $fill stage pipeline
6 participants