Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Jest fake timers check more robust to other libs that overwrite time functions #12527

Merged
merged 1 commit into from Oct 5, 2022
Merged

fix: make Jest fake timers check more robust to other libs that overwrite time functions #12527

merged 1 commit into from Oct 5, 2022

Conversation

vkarpov15
Copy link
Collaborator

Fix #12514

Summary

See discussion from #12524.

Examples

@vkarpov15 vkarpov15 mentioned this pull request Oct 5, 2022
Closed
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 👍

@vkarpov15 vkarpov15 merged commit 573e5bc into master Oct 5, 2022
@Uzlopak Uzlopak deleted the vkarpov15/gh-12514 branch October 5, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jest mock timer warning without using fake timers
2 participants
@vkarpov15 @AbdelrahmanHafez