fix(document): set defaults on subdocuments underneath init-ed single nested subdocument #12523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nested subdocument Fix #12515
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12515
Summary
There was a bug with our fix for #12328 (47ce125): we were really trying to just skip applying defaults on the initial construction of the document. But we ended up skipping applying defaults for the rest of the subdocument's lifecycle, which introduces the bug pointed out in #12515. With this fix, we're only skipping applying defaults on the initial subdocument creation, as intended.
Examples