Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(subdocs): clarify that populated docs are not subdocs #12521

Merged
merged 1 commit into from Oct 5, 2022

Conversation

vkarpov15
Copy link
Collaborator

Fix #12398

Summary

We don't mention anywhere in the subdocuments docs that populated documents are not subdocuments. Should clarify that so people know exactly what is a subdocument and what isn't a subdocument, before clarifying what subdocuments do.

Examples

Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Oct 5, 2022
@vkarpov15 vkarpov15 merged commit eb292d2 into master Oct 5, 2022
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12398 branch October 5, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongoose not saving nested documents
4 participants