Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add "estimatedDocumentCount" and "countDocuments" as possible hooks #12519

Merged
merged 1 commit into from Oct 4, 2022
Merged

fix(types): add "estimatedDocumentCount" and "countDocuments" as possible hooks #12519

merged 1 commit into from Oct 4, 2022

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Oct 4, 2022

Summary

This PR adds estimatedDocumentCount and countDocuments as possible hooks in the types, plus tests

fixes #12516

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Oct 4, 2022
@hasezoey hasezoey added this to the 6.6.5 milestone Oct 4, 2022
vkarpov15
vkarpov15 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 140524c into Automattic:master Oct 4, 2022
@hasezoey hasezoey deleted the addQueryMiddleware branch October 5, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
6.6.5
Development

Successfully merging this pull request may close these issues.

Typescript -- MongooseQueryMiddleware not include countDocuments and estimatedDocumentCount but only count
2 participants
@hasezoey @vkarpov15