v6.6.4 breaks typings with mongodb v4.10.0

[christos97]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Mongoose version

6.6.4

Node.js version

14.19.1

MongoDB server version

5.0.12

Description

Updating from 6.6.3 -> 6.6.4 breaks the typings of node_modules/mongoose/types/query.d.ts

Using the current latest version of mongodb npm package (4.10.0)

This error has happened before with different version comboinations.

Its the "classic"

Exrpession expected or '(' expected

We do not have mongoose typings installed separately as a dev depedency,
only mongodb and mongoose packages at the above versions mentioned

Steps to Reproduce

Update versions and run npm install.
The error is coming from within mongoose module typings.

node_modules/mongoose/types/query.d.ts:630:191 - error TS1005: ',' expected.

630     updateMany(filter?: FilterQuery<DocType>, update?: UpdateQuery<DocType> | UpdateWithAggregationPipeline, options?: QueryOptions<DocType> | null, callback?: Callback<UpdateWriteOpResult>): QueryWithHelpers<UpdateWriteOpResult, DocType, THelpers, RawDocType>;
                                                                                                                                                                                                  ~

node_modules/mongoose/types/query.d.ts:630:261 - error TS1005: '(' expected.

630     updateMany(filter?: FilterQuery<DocType>, update?: UpdateQuery<DocType> | UpdateWithAggregationPipeline, options?: QueryOptions<DocType> | null, callback?: Callback<UpdateWriteOpResult>): QueryWithHelpers<UpdateWriteOpResult, DocType, THelpers, RawDocType>;
                                                                                                                                                                                                                                                                        ~

node_modules/mongoose/types/query.d.ts:636:22 - error TS1109: Expression expected.

636     updateOne(filter?: FilterQuery<DocType>, update?: UpdateQuery<DocType> | UpdateWithAggregationPipeline, options?: QueryOptions<DocType> | null, callback?: Callback<UpdateWriteOpResult>): QueryWithHelpers<UpdateWriteOpResult, DocType, THelpers, RawDocType>;
                         ~

node_modules/mongoose/types/query.d.ts:636:44 - error TS1109: Expression expected.

636     updateOne(filter?: FilterQuery<DocType>, update?: UpdateQuery<DocType> | UpdateWithAggregationPipeline, options?: QueryOptions<DocType> | null, callback?: Callback<UpdateWriteOpResult>): QueryWithHelpers<UpdateWriteOpResult, DocType, THelpers, RawDocType>;
                                               ~

node_modules/mongoose/types/query.d.ts:636:53 - error TS1109: Expression expected.

636     updateOne(filter?: FilterQuery<DocType>, update?: UpdateQuery<DocType> | UpdateWithAggregationPipeline, options?: QueryOptions<DocType> | null, callback?: Callback<UpdateWriteOpResult>): QueryWithHelpers<UpdateWriteOpResult, DocType, THelpers, RawDocType>;
                                                        ~

node_modules/mongoose/types/query.d.ts:636:76 - error TS1005: '(' expected.

636     updateOne(filter?: FilterQuery<DocType>, update?: UpdateQuery<DocType> | UpdateWithAggregationPipeline, options?: QueryOptions<DocType> | null, callback?: Callback<UpdateWriteOpResult>): QueryWithHelpers<UpdateWriteOpResult, DocType, THelpers, RawDocType>;
                                                                               ~

node_modules/mongoose/types/query.d.ts:636:117 - error TS1109: Expression expected.

636     updateOne(filter?: FilterQuery<DocType>, update?: UpdateQuery<DocType> | UpdateWithAggregationPipeline, options?: QueryOptions<DocType> | null, callback?: Callback<UpdateWriteOpResult>): QueryWithHelpers<UpdateWriteOpResult, DocType, THelpers, RawDocType>;
                                    

Expected Behavior

Since its a patch, this should not happend imho.

[christos97]

Downgrading to previous patch (6.6.3), works as expected and compiles fine.

[hasezoey]

looks like a too low typescript version is used, maybe try to upgrade the typescript version

officially mongoose uses and tests on typescript 4.8 (since at least 6.6.0), though older typescript versions may get fixes, but it is recommended to upgrade to the latest typescript version

[christos97]

Yes upgrading to 4.8 compiles fine.

Thank you. You can close it

"typescript": "~4.8.x"

[christos97]

Hello again,

Maybe you could add a typescript version in the above issue template (if used)
since it's tightly coupled with bugs.

Just an afterthought of course.