Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(schema): correct example for Schema.prototype.discriminator() #12493

Merged
merged 3 commits into from Oct 3, 2022
Merged

docs(schema): correct example for Schema.prototype.discriminator() #12493

merged 3 commits into from Oct 3, 2022

Conversation

vkarpov15
Copy link
Collaborator

Fix #12455

Summary

Quick docs fix since the current example doesn't use the actual function the docs are describing

Examples

hasezoey
hasezoey approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maybe add the following suggestions to make it clear that the document is a document of the discriminated model

lib/schema.js Show resolved Hide resolved
lib/schema.js Outdated Show resolved Hide resolved
@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Oct 1, 2022
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

vkarpov15 and others added 2 commits October 3, 2022 11:33
@vkarpov15 @hasezoey
Update lib/schema.js
1ceb20d 
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 @hasezoey
Update lib/schema.js
3a9e5ac 
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 vkarpov15 merged commit 6d1af00 into master Oct 3, 2022
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12455 branch October 3, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema.prototype.discriminator example is not showing usage of correct function
3 participants
@vkarpov15 @hasezoey @AbdelrahmanHafez