fix(query): treat findOne(_id) as equivalent to findOne({ _id })
#12485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
Uzlopak
reviewed
Sep 29, 2022
test/query.test.js
Outdated
| const Test = db.model('Test', testSchema); | ||
| const _id = new mongoose.Types.ObjectId(); | ||
|
|
||
| const q = Test.find(_id); |
There was a problem hiding this comment.
can we have also a test for findOne please?
IslandRhythms
approved these changes
Sep 29, 2022
hasezoey
added a commit
to hasezoey/mongoose
that referenced
this pull request
Sep 30, 2022
Uzlopak
pushed a commit
that referenced
this pull request
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12325
Summary
#12325 pointed out that, in Mongoose 5,
findOne(ObjectId)worked the same asfindById(ObjectId). I don't see any reason why we shouldn't continue to support this behavior.Examples