fix(timestamps): findOneAndUpdate creates subdocs with timestamps in reverse order #12484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reverse order closes Automattic#12475
|
makes sense |
Uzlopak
approved these changes
Sep 29, 2022
justinpage
reviewed
Sep 29, 2022
| }, { upsert: true, new: true, runValidators: true }); | ||
|
|
||
| for (const address of newItem.addresses) { | ||
| const expected = `{"location":"${address.location}","_id":"${address._id}","createdAt":"${address.createdAt.toISOString()}","updatedAt":"${address.updatedAt.toISOString()}"}`; |
There was a problem hiding this comment.
Would it help to make this multiline? Just for readability?
justinpage
reviewed
Sep 29, 2022
| @@ -1026,6 +1026,30 @@ describe('timestamps', function() { | |||
| assert.equal(doc.sections.length, 1); | |||
| assert.equal(doc.sections[0].title, 'h1'); | |||
| }); | |||
|
|
|||
| it('findOneAndUpdate creates subdocuments with timestamps in reverse order', async function() { | |||
There was a problem hiding this comment.
I noticed the test cases listed here include the Github issue (e.g. gh-12475).
Also, wouldn't we describe this as:
findOneAndUpdate creates subdocuments with timestamps in the expected order
At least, that's how I'm reading the expected variable.
|
Thank you @lpizzinidev for having a fix for this. Appreciate it. |
vkarpov15
approved these changes
Sep 30, 2022
|
|
||
| for (const address of newItem.addresses) { | ||
| const expected = `{"location":"${address.location}","_id":"${address._id}","createdAt":"${address.createdAt.toISOString()}","updatedAt":"${address.updatedAt.toISOString()}"}`; | ||
| assert.equal(JSON.stringify(address), expected); |
There was a problem hiding this comment.
I wouldn't recommend testing the JSON.stringify() output, because that is typically not very readable. I would rather this test that Object.keys(address.toObject()) has 'createdAt' before 'updatedAt'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12475