fix(types): add "array of array key-value pairs" as a argument option for "query.sort()" #12483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
changed the title
… for "query.sort()" fixes Automattic#12434
hasezoey
force-pushed
the
fixSortArray
branch
from
0a1baf5
to
0efe914
Compare
AbdelrahmanHafez
approved these changes
Sep 29, 2022
|
Force pushed to fix a commit message and a oversight in the test types |
AbdelrahmanHafez
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a type for the "array of array with key-value pairs" as a possible type
also adds some more documentation about this way to the jsdoc
fixes #12434
was broken by #11852