Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add sanitizeFilter to types #12465

Merged
merged 5 commits into from Sep 25, 2022
Merged

chore: Add sanitizeFilter to types #12465

merged 5 commits into from Sep 25, 2022

Conversation

zrosenbauer
Copy link
Contributor

@zrosenbauer zrosenbauer commented Sep 22, 2022

Summary

Adding sanitizeFilter to the types as in the index.js.

Note: I know some things are already missing and not sure if they are meant to be "private" and exported for convenience (i.e. skipMiddlewareFunction).

Examples

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Sep 23, 2022
types/index.d.ts Outdated Show resolved Hide resolved
@AbdelrahmanHafez
Copy link
Collaborator

Welcome @zrosenbauer 👋
Can you please add type tests in test/types to prevent future regressions?

zrosenbauer and others added 2 commits September 23, 2022 11:27
Co-authored-by: Hafez <a.hafez852@gmail.com>
@zrosenbauer
Copy link
Contributor Author

Welcome @zrosenbauer 👋 Can you please add type tests in test/types to prevent future regressions?

Added a test, let me know if we need more (figured a simple one like that would suffice)

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.6.2 milestone Sep 25, 2022
@vkarpov15 vkarpov15 merged commit e6ac7e8 into Automattic:master Sep 25, 2022
@zrosenbauer zrosenbauer deleted the chore/add-sanitizeFilter-to-types branch September 25, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants