Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DiscriminatorSchema to have better names and combine statics #12460

Merged
merged 3 commits into from Sep 27, 2022
Merged

Update DiscriminatorSchema to have better names and combine statics #12460

merged 3 commits into from Sep 27, 2022

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR updates DiscriminatorSchema to:

  • have better and more reasonable names
  • also transfer & combine all statics from both schemas

also see #12457 (which could make this PR obsolete when resolved)

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Sep 22, 2022
vkarpov15
vkarpov15 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 3016f67 into Automattic:master Sep 27, 2022
@vkarpov15 vkarpov15 added this to the 6.6.3 milestone Sep 27, 2022
@hasezoey hasezoey deleted the updateDiscriminatorSchema branch September 27, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
6.6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasezoey @vkarpov15