Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove unused defaults in "PluginFunction" #12459

Merged
merged 1 commit into from Sep 27, 2022

Conversation

hasezoey
Copy link
Collaborator

Summary

Remove default from helper type PluginFunction, these default are unnecessary because all values are passed-through from where the helper type is used and so they go always unused

i already did a ts-benchmark, but nothing changed (Instantiations are the same as master and this branch, and time is within margin of error)

Should improve some typescript performance
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Sep 22, 2022
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.6.3 milestone Sep 27, 2022
@vkarpov15 vkarpov15 merged commit d78d631 into Automattic:master Sep 27, 2022
@hasezoey hasezoey deleted the removeDefaultPluginType branch September 27, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants