PR #12254 introduced bug: Methods defined in shared schemas get removed

[maximilianschmid]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Mongoose version

6.5.5

Node.js version

16.6

MongoDB server version

6.0.1

Description

PR #12254 introduces a bug
where instance methods defined in shared schema get deleted.

Problem located in line 38 in file
mongoose/lib/helpers/model/applyMethods.js

Commit
9fbf92c#diff-9de3851c9d06234f6bef122196730d35ce2dc68fc2b609824b1676194608e4fb

Steps to Reproduce

1. Install mongoose 6.5.5
2. Run this bug demo script:

const mongoose = require('mongoose')
mongoose.set('debug', true)

const sharedSubSchema = new mongoose.Schema({
  name: {
    type: String
  }
})

sharedSubSchema.methods.sharedSubSchemaMethod = function () {
  console.log('sharedSubSchemaMethod called')
}

const mainDocumentSchema = new mongoose.Schema({
  subdocuments: {
    type: [sharedSubSchema],
    required: true
  }
})
const MainDocument = mongoose.model('MainDocument', mainDocumentSchema)

const secondaryDocumentSchema = new mongoose.Schema({
  subdocuments: {
    type: [sharedSubSchema],
    required: true
  }
})
const SecondaryDocument = mongoose.model('SecondaryDocument', secondaryDocumentSchema)

const mainDoc = new MainDocument({
  subdocuments: [
    {
      name: 'one'
    }
  ]
})

const secondaryDoc = new SecondaryDocument({
  subdocuments: [
    {
      name: 'secondary'
    }
  ]
})

console.log(mainDoc.subdocuments[0].sharedSubSchemaMethod)
console.log(secondaryDoc.subdocuments[0].sharedSubSchemaMethod)

Expected Behavior

Sub-Document method should be defined on both models, not only one.

Buggy output mongoosejs 6.5.5
[Function (anonymous)]
undefined

Correct output mongoosejs 6.5.4
[Function (anonymous)]
[Function (anonymous)]

[IslandRhythms]

const mongoose = require('mongoose')
mongoose.set('debug', true)

const sharedSubSchema = new mongoose.Schema({
  name: {
    type: String
  }
})

sharedSubSchema.methods.sharedSubSchemaMethod = function () {
  console.log('sharedSubSchemaMethod called')
}

const mainDocumentSchema = new mongoose.Schema({
  subdocuments: {
    type: [sharedSubSchema],
    required: true
  }
})
const MainDocument = mongoose.model('MainDocument', mainDocumentSchema)

const secondaryDocumentSchema = new mongoose.Schema({
  subdocuments: {
    type: [sharedSubSchema],
    required: true
  }
})
const SecondaryDocument = mongoose.model('SecondaryDocument', secondaryDocumentSchema)


async function run() {
  await mongoose.connect('mongodb://localhost:27017');
  await mongoose.connection.dropDatabase();
  
  const mainDoc = await MainDocument.create({
    subdocuments: [
      {
        name: 'one'
      }
    ]
  })
  
  const secondaryDoc = await SecondaryDocument.create({
    subdocuments: [
      {
        name: 'secondary'
      }
    ]
  })
  
  console.log(mainDoc.subdocuments[0].sharedSubSchemaMethod)
  console.log(secondaryDoc.subdocuments[0].sharedSubSchemaMethod)
}

run();

[maximilianschmid]

👍

[maximilianschmid]

Just to clarify: version 6.6.0 also has this bug.

[backflip]

Just stumbled upon the same problem. For reference: The corresponding PR is #12391

[maximilianschmid]

Thx!