Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use setPrototypeOf() instead of __proto__ to allow running on Deno" #12314

Merged
merged 1 commit into from Aug 23, 2022
Merged

Revert "Use setPrototypeOf() instead of __proto__ to allow running on Deno" #12314

merged 1 commit into from Aug 23, 2022

Conversation

AbdelrahmanHafez
Copy link
Collaborator

Reverts #12313

@AbdelrahmanHafez AbdelrahmanHafez merged commit 2de1a86 into master Aug 23, 2022
@Uzlopak Uzlopak deleted the revert-12313-vkarpov15/gh-9056 branch August 23, 2022 06:46
@hasezoey
Copy link
Collaborator

what was the reason that this change was reverted?

@Uzlopak
Copy link
Collaborator

Uzlopak commented Aug 23, 2022

@hasezoey
It was merged into the wrong target (master vs. 6.6)

@AbdelrahmanHafez
Copy link
Collaborator Author

We're merging this in 6.6 branch instead of master, see #12315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AbdelrahmanHafez @hasezoey @Uzlopak