Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): apply changes from #11563 to "connection.model" #12240

Merged
merged 1 commit into from Aug 9, 2022
Merged

fix(types): apply changes from #11563 to "connection.model" #12240

merged 1 commit into from Aug 9, 2022

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Aug 9, 2022

Summary

This PR apply the changes from #11563 to connection.model

fixes #12129

PS: for now i have just let the old connection.model types stay there as fallbacks, i dont know if they can be removed without breaking something

vkarpov15
vkarpov15 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 I took a look and confirmed this doesn't cause perf degradation

@vkarpov15 vkarpov15 added this to the 6.5.2 milestone Aug 9, 2022
@vkarpov15 vkarpov15 merged commit 206f377 into Automattic:master Aug 9, 2022
@hasezoey hasezoey deleted the fix12129 branch August 9, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.2
Development

Successfully merging this pull request may close these issues.

mongoose\types\connection.d.ts has incorrect definition for model
2 participants
@hasezoey @vkarpov15