Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bulkWrite's type parameter conditional #12221

Merged

Conversation

sandersn
Copy link
Contributor

@sandersn sandersn commented Aug 5, 2022

Smaller alternative fix to #12212.
Also fixes #12213, but unsafely when the model's type parameter allows null or undefined.

Smaller alternative fix to Automattic#12212.
Also fixes Automattic#12213, but unsafely when the model's type parameter allows
null or undefined.
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.5.2 milestone Aug 8, 2022
@vkarpov15 vkarpov15 merged commit 9487c45 into Automattic:master Aug 8, 2022
@sandersn sandersn deleted the bulkWrite-conditional-type-parameter branch August 9, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error with Typescript 4.8 beta on type from mongodb@4.8.1
2 participants