Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some Documentation things #12199

Merged
merged 13 commits into from Aug 9, 2022
Merged

Fix some Documentation things #12199

merged 13 commits into from Aug 9, 2022

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Aug 2, 2022

Summary

This PR does:

  • fix index (home page) footer Sponsor text
  • fix index (home page) header size
  • enhance handling of badly formatted @see tags
  • fix badly formatted @see tags
  • move styles from api_split.pug into api.css
  • remove file track.pug (because empty)
  • change list text for enterprise.md to be indented to be properly formatted
  • fix code in headers (markdown only applies if a new empty line separates html and markdown)
  • add padding for list elements in migrating_to_6
  • remove one TOC from schematypes.md

vkarpov15
vkarpov15 reviewed Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just 1 question/comment

docs/migrating_to_6.md Outdated Show resolved Hide resolved
vkarpov15
vkarpov15 requested changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just marking this as "request changes" to show that it's already been reviewed

@hasezoey
Copy link
Collaborator Author

hasezoey commented Aug 4, 2022

Force pushed to drop the original migrating_to_6.md header change commit and added a new c34c076

@hasezoey hasezoey requested a review from vkarpov15 August 4, 2022 09:24
vkarpov15
vkarpov15 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.5.2 milestone Aug 9, 2022
@vkarpov15 vkarpov15 merged commit 7b41035 into Automattic:master Aug 9, 2022
@hasezoey hasezoey deleted the fixDocs branch August 9, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasezoey @vkarpov15