Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add "code" to Headers (and index list) #12152

Merged
merged 2 commits into from Aug 3, 2022

Conversation

hasezoey
Copy link
Collaborator

Summary

(continuation of #12145 (comment))

This PR adds code blocks to the headers and the index list:

Headers

before:
headers before

after:
headers after

Index List

before:
index list before

after:
index list after

PS: yes this change does not screw up any anchor ids or click-ablility

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Uzlopak
Copy link
Collaborator

Uzlopak commented Jul 27, 2022

Hmm actually it looks counter intuitive. I would actually not expect a hyperlink

@hasezoey
Copy link
Collaborator Author

I would actually not expect a hyperlink

for what, the header or the index list, or both? i actually think having code as code is standard across some documentation projects

@Uzlopak
Copy link
Collaborator

Uzlopak commented Jul 27, 2022

The header is somehow ok. But the menu looks weitd

@hasezoey
Copy link
Collaborator Author

hasezoey commented Aug 2, 2022

@Uzlopak do you think the index list would look better with text-decorations: underline?
(or maybe only the mentioned rule when hovered?)

@vkarpov15 vkarpov15 merged commit da80e5b into Automattic:master Aug 3, 2022
@vkarpov15 vkarpov15 added this to the 6.5.1 milestone Aug 3, 2022
@hasezoey hasezoey deleted the addCodeToHeaders branch August 3, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants