Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch-up JSDOC of some more files #12140

Merged
merged 8 commits into from Jul 25, 2022
Merged

Touch-up JSDOC of some more files #12140

merged 8 commits into from Jul 25, 2022

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR does:

  • touch-up some more file for JSDOC, for:
    • lib/aggregate.js
    • lib/cast.js
    • lib/collection.js
    • lib/connection.js
    • lib/document.js
  • replace all old (broken) links #\w+_\w+\. to be #\w+_\w+- (from #model_Model.find to #model_Model-find)

@hasezoey hasezoey mentioned this pull request Jul 22, 2022
Merged
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Jul 23, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@vkarpov15 vkarpov15 added this to the 6.4.7 milestone Jul 25, 2022
@vkarpov15 vkarpov15 merged commit 7ff925b into Automattic:master Jul 25, 2022
@hasezoey hasezoey deleted the jsdoc branch July 26, 2022 10:00
@k4y3ff k4y3ff mentioned this pull request Oct 16, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hasezoey @vkarpov15 @AbdelrahmanHafez