fix(types): map correct generics from model to schema #12125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emiljanitzek
force-pushed
the
feature/model-schema-type
branch
6 times, most recently
from
3e2ae76
to
dd0dd96
Compare
vkarpov15
reviewed
Jul 25, 2022
test/types/models.test.ts
Outdated
| interface UserInstanceMethods { | ||
| findByName(name: string): Promise<HydratedDocument<User>>; | ||
| } | ||
| type UserModel = Model<User, UserQueryHelpers> & UserInstanceMethods; |
There was a problem hiding this comment.
Seems a little odd that UserInstanceMethods is part of the UserModel type. You shouldn't be able to do UserModel.findByName()...
There was a problem hiding this comment.
You are correct, I think the confusion came from TInstanceMethod and TStaticMethods on Schema and TMethodsAndOverrides on Model which is the same as TInstanceMethod. I've renamed the interfaces in the test and added statics too.
emiljanitzek
force-pushed
the
feature/model-schema-type
branch
from
dd0dd96
to
343ff7b
Compare
emiljanitzek
force-pushed
the
feature/model-schema-type
branch
from
343ff7b
to
e6128cb
Compare
vkarpov15
approved these changes
Aug 3, 2022
hasezoey
added a commit
to hasezoey/mongoose
that referenced
this pull request
Aug 19, 2022
hasezoey
added a commit
to hasezoey/mongoose
that referenced
this pull request
Aug 19, 2022
vkarpov15
added a commit
that referenced
this pull request
Aug 21, 2022
[types] Apply #12125 to Connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It is not possible to define a model with both generic
TInstanceMethodsandTQueryHelpers. There is a mismatch between generics for themodeland the theSchema.Examples
See type test for example