feat(model): add hydrate option to Model.watch() to automatically hydrate fullDocument
#12121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hydrate `fullDocument` Fix #11936
|
|
||
| let maybePromise = this.driverChangeStream.next(cb); | ||
| if (maybePromise && typeof maybePromise.then === 'function') { | ||
| maybePromise = maybePromise.then(data => { |
There was a problem hiding this comment.
Smart usage of promises right there.
IslandRhythms
approved these changes
Jul 26, 2022
AbdelrahmanHafez
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11936
Summary
Automatically hydrate
fullDocumentifhydrate: trueis set, but only if you callModel.watch().Connection.prototype.watch()doesn't supporthydrate: true.Helpful because 1) it might be hard to figure out what function you need to call to init a Mongoose document without setting anything modified or firing setters, 2) this makes it easier for us to add a global
hydrateFullDocumentoption so we can do this on allModel.watch()calls by default.Examples