Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isAtlas check not working properly #12110

Merged
merged 1 commit into from Jul 16, 2022

Conversation

skrtheboss
Copy link
Contributor

Summary

Use ServerDescription methods for getting server host and port instead of parsing hostname,
which did not work properly.

Examples

Closes #12063

Use ServerDescription methods for getting server host and port instead of parsing hostname,
which did not work properly.

Closes Automattic#12063
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.4.5 milestone Jul 16, 2022
@vkarpov15 vkarpov15 merged commit f95373d into Automattic:master Jul 16, 2022
@skrtheboss skrtheboss deleted the fix/is-atlas-check branch July 17, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongoose dosen't throw error when network disconnected
2 participants