Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): fix $switch expression type #12088

Merged
merged 2 commits into from Jul 15, 2022
Merged

fix(types): fix $switch expression type #12088

merged 2 commits into from Jul 15, 2022

Conversation

AbdelrahmanHafez
Copy link
Collaborator

$switch statements accept branches instead of the current $branches, case instead of $case, and default instead of $default.

@AbdelrahmanHafez AbdelrahmanHafez changed the title test(types): test $switch expression type fix(types): fix $switch expression type Jul 11, 2022
@AbdelrahmanHafez AbdelrahmanHafez added the typescript Types or Types-test related issue / Pull Request label Jul 11, 2022
@AbdelrahmanHafez AbdelrahmanHafez added this to the 6.4.5 milestone Jul 11, 2022
vkarpov15
vkarpov15 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 3e5fa8c into master Jul 15, 2022
@vkarpov15 vkarpov15 deleted the ts-fix-switch branch July 15, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
6.4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbdelrahmanHafez @vkarpov15