Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add $let as a possible expression to $addFields #12087

Merged
merged 2 commits into from Jul 15, 2022

Conversation

AbdelrahmanHafez
Copy link
Collaborator

Aggregation pipeline types currently don't accept the valid
$addFields: { myFieldName: { $let: { /* $let expression goes here */ } } }

This PR fixes that, although I'm not sure if adding Expression.Let follows the desired structure for types.

@AbdelrahmanHafez AbdelrahmanHafez changed the title fix(types): test $let as a possible expression to $addFields fix(types): add $let as a possible expression to $addFields Jul 11, 2022
@AbdelrahmanHafez AbdelrahmanHafez added the typescript Types or Types-test related issue / Pull Request label Jul 11, 2022
@AbdelrahmanHafez AbdelrahmanHafez added this to the 6.4.5 milestone Jul 11, 2022
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit c48461a into master Jul 15, 2022
@vkarpov15 vkarpov15 deleted the ts-aggregation-let branch July 15, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants