Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Auto typed schema. #12042

Merged
merged 8 commits into from Jul 15, 2022
Merged

Conversation

mohammad0-0ahmad
Copy link
Contributor

@mohammad0-0ahmad mohammad0-0ahmad commented Jul 2, 2022

Related to: 12030

@mohammad0-0ahmad mohammad0-0ahmad changed the title Improve Auto typed schema. [WIP] Improve Auto typed schema. Jul 2, 2022
@mohammad0-0ahmad mohammad0-0ahmad changed the title [WIP] Improve Auto typed schema. [X] Improve Auto typed schema. Jul 4, 2022
@mohammad0-0ahmad mohammad0-0ahmad changed the title [X] Improve Auto typed schema. Improve Auto typed schema. Jul 4, 2022
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

});

expectType<{
track?: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion in #12030, this should ideally be track: { backupCount: number; count: number; }. But I don't think that's significant enough to block merging and shipping this PR, because it's a meaningful improvement. Feel free to put in a separate PR.

@vkarpov15 vkarpov15 added this to the 6.4.5 milestone Jul 15, 2022
@vkarpov15 vkarpov15 merged commit 23b2512 into Automattic:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants