Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types in index.d.ts - bulkSave in Model interface #12019

Closed
2 tasks done
pavanyekabote opened this issue Jun 30, 2022 · 3 comments
Closed
2 tasks done

Missing types in index.d.ts - bulkSave in Model interface #12019

pavanyekabote opened this issue Jun 30, 2022 · 3 comments
Milestone

Comments

@pavanyekabote
Copy link

pavanyekabote commented Jun 30, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

version: 5.x

In model.js Model has a method bulkSave, but it is not added in the Model interface of index.d.ts. This creates an issue while using typescript with strict typechecking.

@vkarpov15 vkarpov15 added this to the 5.13.15 milestone Jul 5, 2022
@vkarpov15
Copy link
Collaborator

This was fixed for 6.x in 6.0.7 with #10745 . Is there anything blocking you from upgrading to 6.0?

@pavanyekabote
Copy link
Author

If I migrate to 6.x, I may have to test everything for backward compatibility. Since on ugrading to 6.x, I have noticed mongoose.connect method's ConnectOptions have changed ( Eg: useUnifiedTopology options is not available in 6.x options ).

@vkarpov15
Copy link
Collaborator

Yep, Mongoose 6 always behaves as if useUnifiedTopology = true. So that option was removed.

We'll do what we can to backport this fix to 5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants