fix(types): change index "weights" to be more explicit #11997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
commented
Jun 28, 2022
AbdelrahmanHafez
approved these changes
Jun 28, 2022
AbdelrahmanHafez
added
the
typescript
AbdelrahmanHafez
added a commit
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the types for index option
weightswas defined asAnyObjectwhich allows only string keys and any value type, but with this changestring | numberkeys are allowed (i dont know if indexes support this, please review) and explicitly set the value type tonumber, because that is the only type mongodb accepts (from what i know)Examples