Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✔️] Auto-typed-virtuals #11908

Merged
merged 15 commits into from Jul 20, 2022

Conversation

mohammad0-0ahmad
Copy link
Contributor

@mohammad0-0ahmad mohammad0-0ahmad commented Jun 7, 2022

Related to auto-typed mongoose.
#11563

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, looks good so far though

types/virtuals.d.ts Outdated Show resolved Hide resolved
@mohammad0-0ahmad
Copy link
Contributor Author

mohammad0-0ahmad commented Jun 7, 2022

Hello @vkarpov15 @Uzlopak!

Please review this when you have time for that, I need to add some details in docs, and It will be done I think.

types/virtuals.d.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of quick notes. I'll review this more later.

docs/typescript/virtuals.md Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 added this to the 6.5 milestone Jun 17, 2022
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohammad0-0ahmad LGTM minus merge conflicts. I changed the branch to 6.5.

@mohammad0-0ahmad
Copy link
Contributor Author

Alright I will fix that, and complete this PR.
I've to make some changes on docs.

@mohammad0-0ahmad mohammad0-0ahmad force-pushed the auto-typed-virtuals branch 2 times, most recently from fa12e62 to 4741531 Compare July 19, 2022 02:58
@mohammad0-0ahmad mohammad0-0ahmad changed the title Auto-typed-virtuals ✔️ Auto-typed-virtuals Jul 19, 2022
@mohammad0-0ahmad mohammad0-0ahmad changed the title ✔️ Auto-typed-virtuals [:heavy_check_mark:] Auto-typed-virtuals Jul 19, 2022
@mohammad0-0ahmad mohammad0-0ahmad changed the title [:heavy_check_mark:] Auto-typed-virtuals ✔️ Auto-typed-virtuals Jul 19, 2022
@mohammad0-0ahmad mohammad0-0ahmad changed the title ✔️ Auto-typed-virtuals [✔️] Auto-typed-virtuals Jul 19, 2022
@vkarpov15 vkarpov15 merged commit 0c92558 into Automattic:6.5 Jul 20, 2022
vkarpov15 added a commit that referenced this pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants