Make strictQuery false by default again

[vkarpov15]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Mongoose version

6.x

Node.js version

Any

MongoDB server version

Any

Description

The strictQuery change in Mongoose 6 (https://mongoosejs.com/docs/migrating_to_6.html#strictquery-is-removed-and-replaced-by-strict) has caused a lot of confusion. Here's a couple:

#11609
#11807
#11514

Etc.

Steps to Reproduce

From #11609:

const mongoose = require('mongoose');

const testSchema = new mongoose.Schema({
    title: [{
        value: String,
        language: String
    }]
});

const Test = mongoose.model('Test', testSchema);

async function run() {
    await mongoose.connect('mongodb://localhost:27017');
    await mongoose.connection.dropDatabase();

    await Test.create({
        title: [{
            value: 'El Dave valencia',
            language: 'ca'
        }, {
            value: 'El Dave castellano',
            language: 'es'
        }]
    });

    await Test.create({
        title: [{
            value: 'test',
            language: 'ca'
        }, {
            value: 'test',
            language: 'es'
        }]
    });

    const query = await Test.find({$or: [{"title.value":/Dave/i},{"name.value":/Dave/i} ]});
    console.log('done', query, query[0].title, query[1].title);
    
}

run();

Expected Behavior

Make strictQuery false by default in Mongoose 7

[hasezoey]

as mentioned in #12389 (comment), what about setting it to throw (or return some kind of validation errors like .validate) instead of reverting to false instead of the current "silently remove things" or going back to include "as is"?

[vkarpov15]

@hasezoey 'strictQuery: throw' by default would be a bit too strict to be a default for Mongoose. Wouldn't fit in well with the rest of our defaults.

[vkarpov15]

We should also decouple strict and strictQuery again. Setting strictQuery to strict by default was a workaround, setting strict: false in your schema shouldn't disable strictQuery.

[ilovepixelart]

@vkarpov15 Glad it will be over soon, can't wait for mongoose 7

[zhi-qiu-yi]

why not merge on v6.x? moving to v7.x takes more problem. @vkarpov15

[hasezoey]

this is a breaking change and so could only be done on a major version change, if you want to disable it globally for 6.x you can use mongoose.set('strictQuery', false) before using any query (like before / after creating the connection)