Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize size of browser bundle, use buffer v.5.7.1 package to match buffer package of mongodb in browser bundle #11765

Merged
merged 3 commits into from May 5, 2022
Merged

optimize size of browser bundle, use buffer v.5.7.1 package to match buffer package of mongodb in browser bundle #11765

merged 3 commits into from May 5, 2022

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented May 3, 2022

  • use buffer v.5.7.1 as a devDependency so that the version matches the buffer package from mongodb.
  • use alias in webpack on bn.js to reduce redundancy, saving about 260 kb

before:
Screenshot from 2022-05-03 23-10-04

after:
Screenshot from 2022-05-03 23-09-48

before:1048 kb
after: 781 kb

@Uzlopak
remove buffer as dependency to enforce the use of the buffer package …
a7df976 
…from mongodb

use alias of bn.js to use only one bn.js instance
@Uzlopak
use buffer 5.7.1
0a8d05d
vkarpov15
vkarpov15 approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.3.3 milestone May 5, 2022
@vkarpov15 vkarpov15 merged commit c232dd7 into Automattic:master May 5, 2022
@Uzlopak Uzlopak deleted the optimize-browser-bundle branch May 5, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uzlopak @vkarpov15