Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix jsdoc for mongoose.createConnection #11693

Merged
merged 1 commit into from Apr 20, 2022
Merged

fix jsdoc for mongoose.createConnection #11693

merged 1 commit into from Apr 20, 2022

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Apr 20, 2022

Resolves #11686

@Uzlopak Uzlopak requested a review from vkarpov15 April 20, 2022 16:17
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@AbdelrahmanHafez AbdelrahmanHafez merged commit b535375 into Automattic:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@vkarpov15 vkarpov15 Awaiting requested review from vkarpov15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createConnection does not return a Promise, as it should
2 participants
@Uzlopak @AbdelrahmanHafez