fix TypeScript declaration file #11513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did u try this fix with next js build? |
u2ly
approved these changes
Mar 10, 2022
|
Ah nice didn't see this PR. I am currently thinking how to avoid such a petty mistake for the future. Maybe adding a .gitignore in types folder and whitelisting only .d.ts files. Would be platform independent and you could not check in the file if it was a normal .ts file. Anyway this PR lgtm! |
|
I added in #11516 logic to avoid again this type of regression. |
vkarpov15
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems like there was a typo in
cursor.tsfile which should be a TypeScript declarationcursor.d.ts. It's blocking builds and tests for some people.closes #11511
closes #11512