Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 11071 #11186

Merged
merged 7 commits into from Jan 9, 2022
Merged

Gh 11071 #11186

merged 7 commits into from Jan 9, 2022

Conversation

IslandRhythms
Copy link
Collaborator

Needed to handle booleans

@IslandRhythms
Copy link
Collaborator Author

I'm not sure how to fix this linter issue because it says that _model is an unexpected token but it is used in the test. ¯_(ツ)_/¯

@IslandRhythms IslandRhythms linked an issue Jan 6, 2022 that may be closed by this pull request
bulkSave bug: "TypeError: path.indexOf is not a function" #11071
Closed
vkarpov15
vkarpov15 requested changes Jan 6, 2022
View reviewed changes
lib/document.js Show resolved Hide resolved
test/model.test.js Outdated Show resolved Hide resolved
@IslandRhythms
Copy link
Collaborator Author

Something I just noticed, should I add a check in document.js for isSelected that returns false if path is a boolean? Otherwise it will throw the typerror because the subsequent methods cannot be called on a boolean.

vkarpov15
vkarpov15 approved these changes Jan 9, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@vkarpov15 vkarpov15 added this to the 6.1.6 milestone Jan 9, 2022
@vkarpov15 vkarpov15 merged commit 8f0bf41 into master Jan 9, 2022
@vkarpov15 vkarpov15 deleted the gh-11071 branch January 9, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.6
Development

Successfully merging this pull request may close these issues.

bulkSave bug: "TypeError: path.indexOf is not a function"
2 participants
@IslandRhythms @vkarpov15