New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of co #10633
get rid of co #10633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Any objection to me merging this? Would rather any additional work be in a sperate PR, because this PR is already making GitHub lag :)
Buffer.from('aGVsbG8gd29ybGQ=', 'base64'), | ||
{ type: 'Buffer', data: [103, 104, 45, 54, 56, 54, 51] } // gh-6863 | ||
] } }).exec().then(tests => { | ||
assert.equal(tests.length, 4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self to fix nasty formatting here
Buffer.from('aGVsbG8gd29ybGQ=', 'base64'), | ||
{ type: 'Buffer', data: [103, 104, 45, 54, 56, 54, 51] } // gh-6863 | ||
] } }).exec().then(tests => { | ||
assert.equal(tests.length, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here too
b: 'bar', | ||
c: 'baz' | ||
}); | ||
await db.$initialConnection; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self to make this asPromise()
@vkarpov15 I'm planning to do more refactoring in a separate PR once this is merged. |
No description provided.