From 73cac1934bd4d0aafcac06e41c906f9560438d48 Mon Sep 17 00:00:00 2001 From: Jorge Yero Salazar Date: Mon, 27 Jun 2022 10:02:55 -0400 Subject: [PATCH 1/3] Allow null as second parameter in ne expression --- types/expressions.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/expressions.d.ts b/types/expressions.d.ts index 6b889e3a827..8663e1a49fb 100644 --- a/types/expressions.d.ts +++ b/types/expressions.d.ts @@ -1034,7 +1034,7 @@ declare module 'mongoose' { * * @see https://docs.mongodb.com/manual/reference/operator/aggregation/ne/#mongodb-expression-exp.-ne */ - $ne: Expression | [Expression, Expression] | null; + $ne: Expression | [Expression, Expression | NullExpression] | null; } export interface Cond { From 8499ecbd363466c805b2e4c9dd1aa33d702280c8 Mon Sep 17 00:00:00 2001 From: Jorge Yero Salazar Date: Mon, 27 Jun 2022 10:03:14 -0400 Subject: [PATCH 2/3] Add expression type test --- test/types/expressions.test.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/types/expressions.test.ts b/test/types/expressions.test.ts index dd889576728..174c5c6e3cd 100644 --- a/test/types/expressions.test.ts +++ b/test/types/expressions.test.ts @@ -164,3 +164,7 @@ const toLong: Expression = { $toLong: '$qty' }; const nullExpr: Expression = { $ne: null }; + +const nullNETupleExpr: Expression = { + $ne: ["$name", null] +}; From ed90a0a25b5ecc5ca5080626dfddcebdf24d2c7d Mon Sep 17 00:00:00 2001 From: Valeri Karpov Date: Fri, 1 Jul 2022 11:58:36 -0400 Subject: [PATCH 3/3] Update expressions.test.ts --- test/types/expressions.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/types/expressions.test.ts b/test/types/expressions.test.ts index 174c5c6e3cd..2ee99e2b82f 100644 --- a/test/types/expressions.test.ts +++ b/test/types/expressions.test.ts @@ -166,5 +166,5 @@ const nullExpr: Expression = { }; const nullNETupleExpr: Expression = { - $ne: ["$name", null] + $ne: ['$name', null] };