From 542a99b92477acb5fb6ca6d72198b5e43cd57dc2 Mon Sep 17 00:00:00 2001 From: Hafez Date: Fri, 20 Mar 2020 10:17:14 +0200 Subject: [PATCH] Refactor #8331 test to prevent false positive --- test/model.test.js | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/test/model.test.js b/test/model.test.js index 28b389c3cc4..e0ea3df06fe 100644 --- a/test/model.test.js +++ b/test/model.test.js @@ -5540,7 +5540,9 @@ describe('Model', function() { return co(function*() { const createdUser = yield User.create({ name: 'Hafez' }); - let threw = false; + + let err; + try { yield User.bulkWrite([{ updateOne: { @@ -5548,17 +5550,16 @@ describe('Model', function() { } }]); } - catch (err) { - threw = true; - assert.equal(err.message, 'Must provide an update object.'); + catch (_err) { + err = _err; } - finally { - assert.equal(threw, true); - const userAfterUpdate = yield User.findOne({ _id: createdUser._id }); + assert.ok(err); + assert.equal(err.message, 'Must provide an update object.'); - assert.equal(userAfterUpdate.name, 'Hafez', 'Document data is not wiped if no update object is provided.'); - } + const userAfterUpdate = yield User.findOne({ _id: createdUser._id }); + + assert.equal(userAfterUpdate.name, 'Hafez', 'Document data is not wiped if no update object is provided.'); }); }); });