Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost: Add check for c.css gen library and add a error UI if unavailable #37091

Closed
dilirity opened this issue Apr 26, 2024 · 1 comment · Fixed by #37283
Closed

Boost: Add check for c.css gen library and add a error UI if unavailable #37091

dilirity opened this issue Apr 26, 2024 · 1 comment · Fixed by #37283
Assignees
@dilirity
Labels
[Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Plugin] Boost A feature to speed up the site and improve performance.

Comments

@dilirity
Copy link
Member

Related pc9hqz-2P1-p2#comment-2091

There's currently no check if the Critical CSS Generator library is available before using it. There are ways for 3rd party code to break the global JS scope (for example this) and the library will no be available correctly in Boost.
@dilirity dilirity added [Plugin] Boost A feature to speed up the site and improve performance. [Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Boost Feature] Cloud CSS labels Apr 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • pc9hqz-2P1-p2#comment-2091

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Apr 26, 2024
@dilirity dilirity removed the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Apr 26, 2024
@dilirity dilirity mentioned this issue Apr 30, 2024
Merged
3 tasks
@dilirity dilirity self-assigned this May 8, 2024
@dilirity dilirity mentioned this issue May 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dilirity dilirity

Labels
[Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Boost: Add check for css gen library before generation attempt Automattic/jetpack
1 participant
@dilirity