Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid of posts 2×3 #303

Closed
iamtakashi opened this issue Nov 8, 2022 · 4 comments
Closed

Grid of posts 2×3 #303

iamtakashi opened this issue Nov 8, 2022 · 4 comments

Comments

@iamtakashi
Copy link
Contributor

iamtakashi commented Nov 8, 2022

Category: Blog, Wireframe

Tag: Pattern, Layout

Screenshot:
dotcompatterns wordpress com__p=8421 preview=true query-16-page=2 (1)

Note: The pattern displays featured images if exist.

Markup:

<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"7vw","bottom":"7vw"},"margin":{"top":"0px","bottom":"0px"}}},"layout":{"inherit":true,"type":"constrained"}} -->
<div class="wp-block-group alignfull" style="margin-top:0px;margin-bottom:0px;padding-top:7vw;padding-bottom:7vw"><!-- wp:query {"queryId":16,"query":{"perPage":6,"pages":0,"offset":"0","postType":"post","order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"exclude","inherit":false},"displayLayout":{"type":"flex","columns":2},"align":"wide"} -->
<div class="wp-block-query alignwide"><!-- wp:post-template -->
<!-- wp:group {"style":{"spacing":{"blockGap":"1.5rem","padding":{"bottom":"1.5rem"}}}} -->
<div class="wp-block-group" style="padding-bottom:1.5rem"><!-- wp:post-featured-image {"isLink":true} /-->

<!-- wp:post-title {"isLink":true,"style":{"elements":{"link":{"color":{"text":"var:preset|color|foreground"}}},"typography":{"lineHeight":"1.3"}},"fontSize":"medium"} /-->

<!-- wp:post-excerpt {"moreText":"Read more","showMoreOnNewLine":false,"fontSize":"small"} /-->

<!-- wp:post-date {"fontSize":"small"} /--></div>
<!-- /wp:group -->
<!-- /wp:post-template -->

<!-- wp:query-pagination {"paginationArrow":"arrow","layout":{"type":"flex","justifyContent":"space-between"}} -->
<!-- wp:query-pagination-previous /-->

<!-- wp:query-pagination-numbers /-->

<!-- wp:query-pagination-next /-->
<!-- /wp:query-pagination --></div>
<!-- /wp:query --></div>
<!-- /wp:group -->

Preview: https://dotcompatterns.wordpress.com/?p=8421&preview=true

cc @alaczek @onuro

@onuro
Copy link

onuro commented Nov 15, 2022

I understand this is for wireframe category but when testing with latest themes like TT3 the medium font size for the post titles seem to be making it hard to differentiate from the rest of the post content.

Also maybe the vertical spacings could need defining.

image

@iamtakashi
Copy link
Contributor Author

@onuro, thanks for reviewing.

latest themes like TT3 the medium font size for the post titles seem to be making it hard to differentiate from the rest of the post content.

Are there more themes like TT3 that have a medium size that is almost the same as small size? TBH, I find TT3's font scale weird because it's very flat.

Also maybe the vertical spacings could need defining.

Wow... TT3's space unit is very "generous". The vertical spacing is defined in the pattern, but TT3 and Blank Canvas 3's unit is weirdly big. Look at the comparison with TT2 below.

TT2 TT3 BC3
iamtakashi jurassic tube__page_id=544 (2) iamtakashi jurassic tube__page_id=544 iamtakashi jurassic tube__page_id=544 (1)

I updated the spacing with absolute value instead so that the vertical spacing will always be the same regardless of the activated theme. Does it look better now?

I'm now worried about BC3 because it's based on TT3, which I find a little opinionated.

This was referenced Nov 16, 2022
@onuro
Copy link

onuro commented Nov 17, 2022

Are there more themes like TT3 that have a medium size that is almost the same as small size? TBH, I find TT3's font scale weird because it's very flat.

I totally agree, TT3 has room to be improved. I'm also going to revisit the font sizings on BC3 as well since TT3 fluid sizes feel a bit lacking contrast. Just awaiting the latest Gutenberg release that improves the fluid typography settings.

And yes looking nice now!

@iamtakashi
Copy link
Contributor Author

Thanks! Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants