Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .net standard support to AutoFoq #1184

Merged
merged 2 commits into from Jun 29, 2020
Merged

Add .net standard support to AutoFoq #1184

merged 2 commits into from Jun 29, 2020

Conversation

josh-degraw
Copy link
Contributor

In reference to #1143, this PR adds .net standard support for AutoFoq.

@aivascu
Copy link
Member

aivascu commented Jun 24, 2020

Hello @josh-degraw!
Thank you for the contribution.
It looks like the current build configuration (visual studio 2015) does not support .NET Core 3+.
I'll see if the are any implications to the upgrade and get back to you.

@josh-degraw
Copy link
Contributor Author

@aivascu Okay, if it's easier I can just change the new target framework I for the unit tests to .NET Core 2.2

@aivascu
Copy link
Member

aivascu commented Jun 27, 2020

@josh-degraw I think changing the target framework, for now, might be the better plan.
I have tried to test the build under the VS 2019 environment, with no success.
I will upgrade the tests to use .NET Core 3, once I am more familiar with F# and FAKE.

@aivascu aivascu self-requested a review June 27, 2020 05:55
aivascu
aivascu approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@aivascu aivascu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@aivascu aivascu merged commit 96744a3 into AutoFixture:master Jun 29, 2020
@zvirja
Copy link
Member

zvirja commented Jun 29, 2020 •
edited

Should we also update readme file to mark it netstandard compatible now?

@aivascu
Copy link
Member

aivascu commented Jun 29, 2020 •
edited

@zvirja you are correct, I missed that. I fixed it in #1186

@josh-degraw josh-degraw deleted the autofoq-netstandard branch June 29, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aivascu aivascu aivascu approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josh-degraw @aivascu @zvirja