Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logs in Backend - deployments #469

Open
ADI10HERO opened this issue Dec 8, 2021 · 7 comments · May be fixed by #475
Open

Add logs in Backend - deployments #469

ADI10HERO opened this issue Dec 8, 2021 · 7 comments · May be fixed by #475
Assignees
@7saikat7
Labels
django Backend/Django related work documentation Improvements or additions to documentation feature New feature or request good first issue Good for newcomers

Comments

@ADI10HERO
Copy link
Member

Feature Request

Is your feature request related to an existing Issue or a new implementation?

No

Feature Description

NOTE: Scope of this issue is limited to deployments

The backend has some random print statements and no logging.
We would like to have logging along with various levels (INFO, WARNING, ERROR)
Print statements can be removed as well.

Possible Solution

Follow some best practices: https://coralogix.com/blog/python-logging-best-practices-tips/
@ADI10HERO ADI10HERO added documentation Improvements or additions to documentation feature New feature or request good first issue Good for newcomers django Backend/Django related work labels Dec 8, 2021
@7saikat7
Copy link

Hi , I am a mentor in swoc , but would love to work on this issue separately, please assign me

@7saikat7
Copy link

just to inform u, it can take a little longer cause I was stuck on setup, get it solved just now, and now will be working on the issue

@7saikat7
Copy link

My previous PR is failed on a different issue ,any guide on how to make proper PR here?

@ADI10HERO
Copy link
Member Author

Hey @7saikat7 please read Readme and Contributing Guidelines. Also please refer to merged PRs to see examples for what's expected.

If you still face problems, please contact via slack.
Thank you :D

@7saikat7
Copy link

Sir, I can see in a fresh clone that logger is already being added to the deployment app, but it's different from the best practice you have mentioned here on the issue . Should I change them to the best practice?
one more thing to ask that can we add other log messages except changing the print statements only?

@ADI10HERO
Copy link
Member Author

Hello @7saikat7,
Yes, you can add more log messages.
Please feel free to update the log messages. However, I wouldn't disturb the configuration of the logger.

@7saikat7
Copy link

Great ! Thanks

@7saikat7 7saikat7 linked a pull request Jan 12, 2022 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@7saikat7 7saikat7

Labels
django Backend/Django related work documentation Improvements or additions to documentation feature New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update logs in deployment app 7saikat7/Auto-DL
2 participants
@ADI10HERO @7saikat7