Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update backend app logging #497

Closed
wants to merge 5 commits into from
Closed

fix: update backend app logging #497

wants to merge 5 commits into from

Conversation

ShreyaPrasad1209
Copy link
Contributor

Pull Request

What does this PR do?

Fixes #471

Added logs in backend app which replace print statements.

What part does this affect?

  • FrontEnd.
  • BackEnd.
  • Documentation.
  • Other. (Please specify below)

Before submitting

  • Was this discussed/approved via a GitHub issue or slack?
  • Did you read the contributor guideline?
  • Did you ensure that there aren't any other open Pull Requests for the same update/change?
  • Did you make sure the title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure the code is clean and docstrings have been added or updated as required?
  • Did you make sure the code is linted/formatted locally prior to submission? (using black and/or prettier)
  • Did you make sure to update the documentation with your changes? (if necessary)

PR review

Anyone in the community is free to review the PR once the tests have passed.

Thank you for contributing to AutoDL. We look forward to your continued support.

@ADI10HERO
Copy link
Member

Hi @ShreyaPrasad1209,
Could you please run black . to autolint your code?
Also there's a conflict in utils.

Please look into it as well :)

@ADI10HERO ADI10HERO changed the title Feat/backend logs fix: update backend app logging Mar 20, 2022
@McTechie
Copy link
Contributor

McTechie commented Oct 9, 2022

Hey, @ShreyaPrasad1209 have you linted the backend as suggested by @ADI10HERO? 👀

Additionally, there appears to be a change in the docs in addition to updating the logs, could we try to handle both different issues in separate PRs?

There also appears to be a conflict so let's resolve them before we're good to merge? xD

@McTechie
Copy link
Contributor

Closing due to inactivity

@McTechie McTechie closed this Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logs in Backend - v1
3 participants
@ShreyaPrasad1209 @ADI10HERO @McTechie